fix: Load p5-sound-adapter to enable AudioNode.connect patch#5300
fix: Load p5-sound-adapter to enable AudioNode.connect patch#5300walterbender merged 1 commit intosugarlabs:masterfrom
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
Screen.Recording.2026-01-24.at.4.27.53.PM.movThis PR doesn't solve the closing of Pie menu issue yet? contex for others: there has been a series of bugs introduced in PR #4990 and this PR supposedly solve them |
This PR is narrowly scoped to fix the regression introduced in PR #4990 where p5-sound-adapter was defined but never loaded because activity.js was requiring p5.sound.min instead. As a result, the AudioNode.connect patch was never applied and synth creation failed. This change ensures the adapter is actually loaded so that audio works correctly again. The Pie menu closing issue appears to be a separate regression from the different pr , but it’s not directly related to the sound adapter loading or the AudioNode patching logic addressed here. So yes — this PR fixes only the audio-related breakage, not the Pie menu behavior. |
fix: Load p5-sound-adapter to enable AudioNode.connect patch