Skip to content

fix: Load p5-sound-adapter to enable AudioNode.connect patch#5300

Merged
walterbender merged 1 commit intosugarlabs:masterfrom
Ashutoshx7:fix/load-p5-sound-adapter
Jan 24, 2026
Merged

fix: Load p5-sound-adapter to enable AudioNode.connect patch#5300
walterbender merged 1 commit intosugarlabs:masterfrom
Ashutoshx7:fix/load-p5-sound-adapter

Conversation

@Ashutoshx7
Copy link
Contributor

fix: Load p5-sound-adapter to enable AudioNode.connect patch

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@zealot-zew
Copy link
Contributor

Screen.Recording.2026-01-24.at.4.27.53.PM.mov

This PR doesn't solve the closing of Pie menu issue yet?

contex for others: there has been a series of bugs introduced in PR #4990 and this PR supposedly solve them

@Ashutoshx7
Copy link
Contributor Author

Ashutoshx7 commented Jan 24, 2026

fix: Load p5-sound-adapter to enable AudioNode.connect patch

This PR is narrowly scoped to fix the regression introduced in PR #4990 where p5-sound-adapter was defined but never loaded because activity.js was requiring p5.sound.min instead. As a result, the AudioNode.connect patch was never applied and synth creation failed. This change ensures the adapter is actually loaded so that audio works correctly again.

The Pie menu closing issue appears to be a separate regression from the different pr , but it’s not directly related to the sound adapter loading or the AudioNode patching logic addressed here. So yes — this PR fixes only the audio-related breakage, not the Pie menu behavior.

@walterbender walterbender merged commit 8c9f79d into sugarlabs:master Jan 24, 2026
5 checks passed
021nirav-blip pushed a commit to 021nirav-blip/musicblocks that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants